← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1475353] Re: _get_host_sysinfo_serial_os fails with different exceptions if the machine-id file is not present or if it is empty

 

** Changed in: nova
       Status: Fix Committed => Fix Released

** Changed in: nova
    Milestone: None => liberty-3

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1475353

Title:
  _get_host_sysinfo_serial_os fails with different exceptions if the
  machine-id file is not present or if it is empty

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  When the sysinfo_serial config parameter for the libvirt driver is set to 'os', the defined behavior is:
  - return the value found in /etc/machine-id file or
  - return an error if the file is not present.
  There is an additional scenario where the file is present but it is empty 
  (https://bugs.launchpad.net/ubuntu/+source/nova/+bug/1413293) in that case we want nova to behave as if the file was missed.
  At the moment the missing file and an empty file return different exceptions:
  - IOError for a missing file
  - IndexError for an empty file
  Both of these errors are too general and don't give a big help in debugging the issue.

  Please note that we do not want to fix the issue about a missing/empty
  machine-id file, that is something related to a bad OS
  installation/configuration or a bad image, the proposed fix is just to
  keep nova behaves consistently and giving back to the user a more
  clear and precise error.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1475353/+subscriptions


References