yahoo-eng-team team mailing list archive

[Matt Riedemann <mriedem@xxxxxxxxxx>]

Public bug reported:

https://github.com/openstack/nova/blob/12.0.0a0/nova/virt/libvirt/driver.py#L4026
is huge, in liberty-3 it's nearly 400 LOC.

We should really look at breaking that up in mitaka since it's too big
to unit test properly and make sure we have the right coverage.

** Affects: nova
     Importance: Low
         Status: Confirmed


** Tags: libvirt low-hanging-fruit testing

** Changed in: nova
       Status: New => Confirmed

** Changed in: nova
   Importance: Undecided => Low

** Changed in: nova
    Milestone: None => next

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1494374

Title:
  nova.virt.libvirt.driver._get_guest_config method is nearly 400 LOC
  and should be broken up

Status in OpenStack Compute (nova):
  Confirmed

Bug description:
  https://github.com/openstack/nova/blob/12.0.0a0/nova/virt/libvirt/driver.py#L4026
  is huge, in liberty-3 it's nearly 400 LOC.

  We should really look at breaking that up in mitaka since it's too big
  to unit test properly and make sure we have the right coverage.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1494374/+subscriptions