yahoo-eng-team team mailing list archive

[OpenStack Infra <1494374@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/470786
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=931503a0d9f3aada186986b90ef73e22d80cf6cb
Submitter: Jenkins
Branch:    master

commit 931503a0d9f3aada186986b90ef73e22d80cf6cb
Author: Maciej Kucia <maciej@xxxxxxxxx>
Date:   Sun Jun 4 23:59:06 2017 +0200

    libvirt: Extract method _guest_add_memory_balloon
    
    Partial-Bug: #1494374
    Change-Id: Ibf3bd59fb4ce5233c26c64ef70a0ab05094ce10d
    Signed-off-by: Maciej Kucia <maciej@xxxxxxxxx>


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1494374

Title:
  nova.virt.libvirt.driver._get_guest_config method is nearly 400 LOC
  and should be broken up

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  https://github.com/openstack/nova/blob/12.0.0a0/nova/virt/libvirt/driver.py#L4026
  is huge, in liberty-3 it's nearly 400 LOC.

  We should really look at breaking that up in mitaka since it's too big
  to unit test properly and make sure we have the right coverage.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1494374/+subscriptions