← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1502930] [NEW] ipset grabs semaphore excessively

 

Public bug reported:

ipset grabs a semaphore on the set_members operation so it ensures only
one caller is modifying the sets. However, set_members is called many
times on a single security group update when an agent is hosting ports
that are all members of the same security groups. It returns early for
all but one of the calls, but not without getting the semaphore first
and spamming the logs. This is an external lock so it's expensive as
well.

** Affects: neutron
     Importance: Undecided
     Assignee: Kevin Benton (kevinbenton)
         Status: New

** Changed in: neutron
     Assignee: (unassigned) => Kevin Benton (kevinbenton)

** Description changed:

  ipset grabs a semaphore on the set_members operation so it ensures only
  one caller is modifying the sets. However, set_members is called many
  times on a single security group update when an agent is hosting ports
  that are all members of the same security groups. It returns early for
  all but one of the calls, but not without getting the semaphore first
- and spamming the logs. This also likely comes at a small performance
- cost.
+ and spamming the logs. This is an external lock so it's expensive as
+ well.

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1502930

Title:
  ipset grabs semaphore excessively

Status in neutron:
  New

Bug description:
  ipset grabs a semaphore on the set_members operation so it ensures
  only one caller is modifying the sets. However, set_members is called
  many times on a single security group update when an agent is hosting
  ports that are all members of the same security groups. It returns
  early for all but one of the calls, but not without getting the
  semaphore first and spamming the logs. This is an external lock so
  it's expensive as well.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1502930/+subscriptions


Follow ups