yahoo-eng-team team mailing list archive

[ZongKai LI <lzklibj@xxxxxxxxxx>]

Public bug reported:

in _test__kill_process, utils.execute has been mocked in following code:
        ...
        with mock.patch.object(utils, 'execute',
                               side_effect=exc) as mock_execute:
        ...
so indeed, no signal will be sent at all, for that, we don't need case test_kill_process_with_different_signal, and don't need signal as parameter for _test__kill_process

** Affects: neutron
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1509941

Title:
  case test_kill_process_with_different_signal is not necessary

Status in neutron:
  New

Bug description:
  in _test__kill_process, utils.execute has been mocked in following code:
          ...
          with mock.patch.object(utils, 'execute',
                                 side_effect=exc) as mock_execute:
          ...
  so indeed, no signal will be sent at all, for that, we don't need case test_kill_process_with_different_signal, and don't need signal as parameter for _test__kill_process

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1509941/+subscriptions