← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1509941] Re: case test_kill_process_with_different_signal is not necessary

 

[Expired for neutron because there has been no activity for 60 days.]

** Changed in: neutron
       Status: Incomplete => Expired

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1509941

Title:
  case test_kill_process_with_different_signal is not necessary

Status in neutron:
  Expired

Bug description:
  in _test__kill_process, utils.execute has been mocked in following code:
          ...
          with mock.patch.object(utils, 'execute',
                                 side_effect=exc) as mock_execute:
          ...
  while in _kill_process, signal will be used in:
      ...
      utils.execute(['kill', '-%d' % kill_signal, pid],
                     run_as_root=self.run_as_root)
      ...
  so indeed, no signal will be sent at all, for that, we don't need case test_kill_process_with_different_signal, and don't need signal as parameter for _test__kill_process

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1509941/+subscriptions


References