yahoo-eng-team team mailing list archive

[lumeihong <lu.meihong@xxxxxxxxxx>]

Public bug reported:

the template used is 'horizon/common/_workflow.html' , the inconsistences are as follows:
1) Do not fill in the required fields, an error message is displayed beyond field; 
2) error message is not marked in red; 

the finally reason is that，the style setting is error in
horizon.modals.js, such as:

// Add field errors.
          $field = $fieldset.find('[name="' + field + '"]');
          $field.closest('.form-group').addClass('error');
          $.each(errors, function (index, error) {
            $field.before(
              '<span class="help-block error">' +
              error + '</span>');
          });

it maybe like this:
// Add field errors.
          $field = $fieldset.find('[name="' + field + '"]');
          $field.closest('.form-group').addClass('has-error');
          $.each(errors, function (index, error) {
            $field.after(
              '<span class="help-block alert alert-danger">' +
              error + '</span>');
          });

** Affects: horizon
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1511231

Title:
  sytle is inconsistence bettwen last step and other steps of wrokflow

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  the template used is 'horizon/common/_workflow.html' , the inconsistences are as follows:
  1) Do not fill in the required fields, an error message is displayed beyond field; 
  2) error message is not marked in red; 

  the finally reason is that，the style setting is error in
  horizon.modals.js, such as:

  // Add field errors.
            $field = $fieldset.find('[name="' + field + '"]');
            $field.closest('.form-group').addClass('error');
            $.each(errors, function (index, error) {
              $field.before(
                '<span class="help-block error">' +
                error + '</span>');
            });

  it maybe like this:
  // Add field errors.
            $field = $fieldset.find('[name="' + field + '"]');
            $field.closest('.form-group').addClass('has-error');
            $.each(errors, function (index, error) {
              $field.after(
                '<span class="help-block alert alert-danger">' +
                error + '</span>');
            });

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1511231/+subscriptions