yahoo-eng-team team mailing list archive

[Doug Hellmann <doug@xxxxxxxxxxxxxxxx>]

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1437745

Title:
  ML2 flat_networks blank config defaults to '*' instead of []

Status in neutron:
  Fix Released

Bug description:
  Problem #1: The description and help for the flat_networks config do
  not explain what the default value is.

  etc/neutron/plugins/ml2/ml2_conf.ini
   # (ListOpt) List of physical_network names with which flat networks
   # can be created. Use * to allow flat networks with arbitrary
   # physical_network names.
   #
   # flat_networks =
   # Example:flat_networks = physnet1,physnet2
   # Example:flat_networks = *

  neutron/plugins/ml2/drivers/type_flat.py
      flat_opts = [
          cfg.ListOpt('flat_networks',
                      default=[],
                      help=_("List of physical_network names with which flat "
                             "networks can be created. Use * to allow flat "
                             "networks with arbitrary physical_network names."))
     ]

  Problem #2:

  The code that verifies the config and validates the provider segment
  for a flat network ends up treating [] the same as ['*']. This means
  that the default is actually ['*']. This leads to bugs like bug
  1424548.

  An attempt to fix it was made in https://review.openstack.org/160842
  but had to be reverted due to bug 1437116.

  Solution:

  Deprecate the unintended default of ['*'] and make the new default []
  which was the original intent.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1437745/+subscriptions