← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1502148] Re: /common/utils.py py34 incompatibility

 

** Changed in: neutron
       Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1502148

Title:
  /common/utils.py py34 incompatibility

Status in neutron:
  Fix Released

Bug description:
  Affected file:  /neutron/common/utils.py
  In method get_random_string(length) string has to be encoded as bytes object before hashing.

  Visible consequence:
  -------------------

  2015-09-23 10:06:26.154 | neutron.tests.unit.common.test_utils.TestGetRandomString.test_get_random_string
  2015-09-23 10:06:26.154 | -------------------------------------------------------------------------------
  2015-09-23 10:06:26.154 | 
  2015-09-23 10:06:26.154 | Captured traceback:
  2015-09-23 10:06:26.154 | ~~~~~~~~~~~~~~~~~~~
  2015-09-23 10:06:26.154 |     Traceback (most recent call last):
  2015-09-23 10:06:26.155 |       File "/home/jenkins/workspace/gate-neutron-python34/neutron/tests/unit/common/test_utils.py", line 729, in test_get_random_string
  2015-09-23 10:06:26.155 |         len(utils.get_random_string(self.length)))
  2015-09-23 10:06:26.155 |       File "/home/jenkins/workspace/gate-neutron-python34/neutron/common/utils.py", line 315, in get_random_string
  2015-09-23 10:06:26.155 |         rndstr += hashlib.sha224(str(random.random())).hexdigest()
  2015-09-23 10:06:26.155 |     TypeError: Unicode-objects must be encoded before hashing

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1502148/+subscriptions


References