yahoo-eng-team team mailing list archive

[OpenStack Infra <1524220@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/255217
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d515a8db880388092b61f4649f8dd0b29a2c5de3
Submitter: Jenkins
Branch:    master

commit d515a8db880388092b61f4649f8dd0b29a2c5de3
Author: Bo Chi <shcbo@xxxxxxxxxx>
Date:   Thu Dec 10 08:42:26 2015 -0500

    reject leading '0's in IPv4 addr to avoid ambiguity
    
    If a IPv4 address has a leading '0', it will be interpreted as an
    octal number, e.g. 10.0.0.011 will be interpreted as 10.0.0.9.
    Users who are not familiar with or not expecting octal interpretation
    will not get the address they intended. Since there is no standard
    around this, we reject leading '0's to avoid ambiguity.
    
    APIImpact
    Change-Id: I3163ba13468c47d385585221d2167fbe31d24010
    Closes-Bug: #1524220


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1524220

Title:
  can update the gateway of subnet with needless "0" in the ip address
  via cli

Status in neutron:
  Fix Released

Bug description:
  [Summary]
  can update the gateway of subnet with needless "0" in the ip address via cli

  [Topo]
  devstack all-in-one node

  [Description and expect result]
  if update the gateway of subnet with needless "0" in the ip address, the needless "0" can be cut off

  [Reproduceable or not]
  reproduceable 

  [Recreate Steps]
  1) create 1 subnet:
  root@45-59:/opt/stack/devstack# neutron subnet-show sub-test
  +-------------------+------------------------------------------------+
  | Field             | Value                                          |
  +-------------------+------------------------------------------------+
  | allocation_pools  | {"start": "100.0.0.100", "end": "100.0.0.200"} |
  | cidr              | 100.0.0.0/24                                   |
  | dns_nameservers   |                                                |
  | enable_dhcp       | True                                           |
  | gateway_ip        | 100.0.0.1                                      |
  | host_routes       |                                                |
  | id                | 00dfe80b-911f-4cf1-8874-77639e6082c5           |
  | ip_version        | 4                                              |
  | ipv6_address_mode |                                                |
  | ipv6_ra_mode      |                                                |
  | name              | sub-test                                       |
  | network_id        | 79292c3a-1c85-4014-b0d7-0f078f1a4ee8           |
  | subnetpool_id     |                                                |
  | tenant_id         | 71209fa21a7343e3b778ec5f4ff45252               |
  +-------------------+------------------------------------------------+

  2)update the gateway of subnet with needless "0" in the ip address:
  root@45-59:/opt/stack/devstack# neutron subnet-update  --gateway 100.0.0.001 sub-test
  Updated subnet: sub-test
  root@45-59:/opt/stack/devstack# neutron subnet-show sub-test
  +-------------------+------------------------------------------------+
  | Field             | Value                                          |
  +-------------------+------------------------------------------------+
  | allocation_pools  | {"start": "100.0.0.100", "end": "100.0.0.200"} |
  | cidr              | 100.0.0.0/24                                   |
  | dns_nameservers   |                                                |
  | enable_dhcp       | True                                           |
  | gateway_ip        | 100.0.0.001    >>>ISSUE, should be 100.0.0.1                              |
  | host_routes       |                                                |
  | id                | 00dfe80b-911f-4cf1-8874-77639e6082c5           |
  | ip_version        | 4                                              |
  | ipv6_address_mode |                                                |
  | ipv6_ra_mode      |                                                |
  | name              | sub-test                                       |
  | network_id        | 79292c3a-1c85-4014-b0d7-0f078f1a4ee8           |
  | subnetpool_id     |                                                |
  | tenant_id         | 71209fa21a7343e3b778ec5f4ff45252               |
  +-------------------+------------------------------------------------+
  root@45-59:/opt/stack/devstack# 

  3) if update the gateway of subnet with needless "0" in the ip address
  via dashboard, no this issue

  
  [Configration]
  reproduceable bug, no need

  [logs]
  reproduceable bug, no need

  [Root cause anlyze or debug inf]
  reproduceable bug

  [Attachment]
  None

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1524220/+subscriptions