← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1509232] Re: If we update a QoSPolicy description, the agents get notified and rules get rewired for nothing

 

Reviewed:  https://review.openstack.org/253928
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=aee20b968a12a683b953b576b7e0090345fd3418
Submitter: Jenkins
Branch:    master

commit aee20b968a12a683b953b576b7e0090345fd3418
Author: Irena Berezovsky <irenab.dev@xxxxxxxxx>
Date:   Sun Dec 6 13:44:27 2015 +0000

    Ignore non rules related qos_policy changes
    
    QoSAgentExtension should invoke QoSAgentDriver
    to reflush qos policy rules only if there is any rules related change.
    QoS policy changes, such as description change, should not cause
    reconfiguration of the qos policy rules.
    
    Closes-Bug: #1509232
    Change-Id: I036b0449c7b5521adeb32602a0c0e6cf2d27510a


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1509232

Title:
  If we update a QoSPolicy description, the agents get notified and
  rules get rewired for nothing

Status in neutron:
  Fix Released

Bug description:
  https://github.com/openstack/neutron/blob/master/neutron/services/qos/qos_plugin.py#L59
  https://github.com/openstack/neutron/blob/master/neutron/services/qos/notification_drivers/message_queue.py

  
  We should be smarter on the message_queue and not send useless notifications, alternativelty we could make the agent smarter and ignore those.

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1509232/+subscriptions


References