yahoo-eng-team team mailing list archive

[OpenStack Infra <1268480@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/263340
Committed: https://git.openstack.org/cgit/openstack/python-openstacksdk/commit/?id=ec30746047636ae5d29ff284f40913609edd6f70
Submitter: Jenkins
Branch:    master

commit ec30746047636ae5d29ff284f40913609edd6f70
Author: LiuNanke <nanke.liu@xxxxxxxxxxxx>
Date:   Tue Jan 5 00:50:08 2016 +0800

    Replace assertTrue(isinstance()) with assertIsInstance()
    
    Some of tests use different method of assertTrue(isinstance(A, B)) or
    assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
    B) provided by testtools.
    
    Change-Id: I39174c7de67e6e20b9eb0b9f463943f5b9cb6be9
    Closes-bug: #1268480


** Changed in: python-openstacksdk
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in Barbican:
  In Progress
Status in Ceilometer:
  Fix Released
Status in Cinder:
  In Progress
Status in CloudRoast:
  New
Status in congress:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in Ironic:
  Fix Released
Status in ironic-python-agent:
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Manila:
  In Progress
Status in neutron:
  Invalid
Status in OpenStack Compute (nova):
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-ironicclient:
  In Progress
Status in python-keystoneclient:
  Fix Released
Status in python-novaclient:
  Fix Released
Status in OpenStack SDK:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  In Progress

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/barbican/+bug/1268480/+subscriptions