yahoo-eng-team team mailing list archive

[OpenStack Infra <1268480@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/263537
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=0495d3d4627c9c87f6936d2e6d6ca1fcdc5910e2
Submitter: Jenkins
Branch:    master

commit 0495d3d4627c9c87f6936d2e6d6ca1fcdc5910e2
Author: Kan <kansks@xxxxxxxxxx>
Date:   Tue Jan 5 02:42:52 2016 +0000

    Replace assertTrue with explicit assertIsInstance
    
    Replace assertTrue(isinstance()) with assertIsInstance().
    
    Change-Id: Ie2dabe3a8da23eba7ff1026311dd44465a7587ab
    Closes-Bug: #1268480


** Changed in: python-ironicclient
       Status: In Progress => Fix Released

** Changed in: neutron
       Status: Invalid => In Progress

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in Barbican:
  In Progress
Status in Ceilometer:
  Fix Released
Status in Cinder:
  In Progress
Status in CloudRoast:
  New
Status in congress:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in Ironic:
  Fix Released
Status in ironic-python-agent:
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Manila:
  In Progress
Status in neutron:
  In Progress
Status in OpenStack Compute (nova):
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-ironicclient:
  Fix Released
Status in python-keystoneclient:
  Fix Released
Status in python-novaclient:
  Fix Released
Status in OpenStack SDK:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  In Progress

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/barbican/+bug/1268480/+subscriptions