← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1268480] Re: assertTrue(isinstance()) in tests should be replace with assertIsInstance()

 

** Also affects: trove
   Importance: Undecided
       Status: New

** Changed in: trove
     Assignee: (unassigned) => yapeng Yang (yang-yapeng)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in Barbican:
  In Progress
Status in Ceilometer:
  Fix Released
Status in Cinder:
  In Progress
Status in CloudRoast:
  New
Status in congress:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in Ironic:
  Fix Released
Status in ironic-python-agent:
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Manila:
  In Progress
Status in neutron:
  In Progress
Status in OpenStack Compute (nova):
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-ironicclient:
  Fix Released
Status in python-keystoneclient:
  Fix Released
Status in python-novaclient:
  Fix Released
Status in OpenStack SDK:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  In Progress
Status in Trove:
  In Progress

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/barbican/+bug/1268480/+subscriptions


References