yahoo-eng-team team mailing list archive

[OpenStack Infra <1268480@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/265584
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=097efaba32c8f27de46b9f4635cabe24e43961de
Submitter: Jenkins
Branch:    master

commit 097efaba32c8f27de46b9f4635cabe24e43961de
Author: LiuNanke <nanke.liu@xxxxxxxxxxxx>
Date:   Sun Jan 10 03:27:07 2016 +0800

    Replace assertTrue(isinstance()) by optimal assert
    
    assertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests
    should be replaced by assertIsInstance(A, B) provided by testtools.
    Closes-bug: #1268480
    
    Change-Id: Ia43c944c56e66631c758cc5146150c2b5abb12ed


** Changed in: murano
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in Barbican:
  In Progress
Status in Ceilometer:
  Fix Released
Status in Cinder:
  In Progress
Status in CloudRoast:
  In Progress
Status in congress:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in Ironic:
  Fix Released
Status in ironic-python-agent:
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in Monasca:
  In Progress
Status in Murano:
  Fix Released
Status in neutron:
  In Progress
Status in OpenStack Compute (nova):
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-ironicclient:
  Fix Released
Status in python-keystoneclient:
  Fix Released
Status in python-manilaclient:
  In Progress
Status in python-novaclient:
  Fix Released
Status in OpenStack SDK:
  Fix Released
Status in python-tuskarclient:
  In Progress
Status in Rally:
  In Progress
Status in Sahara:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  In Progress
Status in Trove:
  Fix Released

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/barbican/+bug/1268480/+subscriptions