yahoo-eng-team team mailing list archive

[Pavel Kholkin <pkholkin@xxxxxxxxxxxx>]

Public bug reported:

'context' is not passed to InstanceList.fill_faults() method.

Previously in sqlalchemy.api level
'instance_fault_get_by_instance_uuids' method doesn't properly used
'context' because 'model_query' inside doesn't really use context
attributes. After switching to enginefacade this problem was found
because we always need real 'context' to store 'session' in it.

The 'context' can be None e.g. when we create new empty InstanceList
object by 'instance_list = objects.InstanceList()' and then call
'instance_list.fill_faults()'
(https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L404-L407)

** Affects: nova
     Importance: Low
     Assignee: Pavel Kholkin (pkholkin)
         Status: New

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1533684

Title:
  InstanceList.fill_faults() method must have 'context' argument

Status in OpenStack Compute (nova):
  New

Bug description:
  'context' is not passed to InstanceList.fill_faults() method.

  Previously in sqlalchemy.api level
  'instance_fault_get_by_instance_uuids' method doesn't properly used
  'context' because 'model_query' inside doesn't really use context
  attributes. After switching to enginefacade this problem was found
  because we always need real 'context' to store 'session' in it.

  The 'context' can be None e.g. when we create new empty InstanceList
  object by 'instance_list = objects.InstanceList()' and then call
  'instance_list.fill_faults()'
  (https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L404-L407)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1533684/+subscriptions