yahoo-eng-team team mailing list archive

[OpenStack Infra <1533684@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/261979
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=86963e60bea60f45d7d730442f6b447f58c3f275
Submitter: Jenkins
Branch:    master

commit 86963e60bea60f45d7d730442f6b447f58c3f275
Author: Pavel Kholkin <pkholkin@xxxxxxxxxxxx>
Date:   Mon Dec 28 15:07:42 2015 +0300

    enginefacade: 'ec2_instance' and 'instance_fault'
    
    Use enginefacade in 'ec2_instance' and 'instance_fault' sections.
    
    Implements: blueprint new-oslodb-enginefacade
    
    Closes-Bug: #1533684
    
    Co-Authored-By: Sergey Nikitin <snikitin@xxxxxxxxxxxx>
    
    Change-Id: I39406c41f8674fff538b15d8e23b4e9258cf5fc3


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1533684

Title:
  InstanceList.fill_faults() method must have 'context' argument

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  'context' is not passed to InstanceList.fill_faults() method.

  Previously in sqlalchemy.api level
  'instance_fault_get_by_instance_uuids' method doesn't properly used
  'context' because 'model_query' inside doesn't really use context
  attributes. After switching to enginefacade this problem was found
  because we always need real 'context' to store 'session' in it.

  The 'context' can be None e.g. when we create new empty InstanceList
  object by 'instance_list = objects.InstanceList()' and then call
  'instance_list.fill_faults()'
  (https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L404-L407)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1533684/+subscriptions