yahoo-eng-team team mailing list archive

[OpenStack Infra <1533330@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/266617
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=5c0611eccd06d04697040b12f7225168efcb10ce
Submitter: Jenkins
Branch:    master

commit 5c0611eccd06d04697040b12f7225168efcb10ce
Author: Henry Nash <henryn@xxxxxxxxxxxxxxxxxx>
Date:   Tue Jan 12 23:58:52 2016 +0000

    Update v3policysample tests to use admin_project not special domain_id
    
    We now support the special admin_project that can be used to grant
    cloud-wide powers. The tests on the v3cloudsample had been half
    updated to use this new facility, but in fact were still using the
    old "patch a domain id in the policy file" approach. As well as
    not testing the new functionality, the current tests were causing
    problems elsewhere since they used a non-UUID domain_id.
    
    Closes-Bug: #1533330
    Change-Id: Ic116cf8715130f6ed6bd5380c1b31d5ef0ca154d


** Changed in: keystone
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1533330

Title:
  Some protection test cases have incorrect domain id setup

Status in OpenStack Identity (keystone):
  Fix Released

Bug description:
  The IdentityTestv3CloudPolicySample test classes has it's own setup
  method, similar to other test classes. The setup method for
  IdentityTestv3CloudPolicySample loads in sample data that can be used
  throughout the tests in the module.

  However, the IdentityTestv3CloudPolicySample setup method creates a
  domain in such a way that is incompatible with how domains are created
  in real world deployments. Keystone doesn't allow admins to specify
  domain_id on request, making it so keystone always issues uuid.hex
  formatted id strings for domain ids. The only domain that is the
  exception to this rule is the default domain id, which is specified in
  keystone's configuration.

  The IdentityTestv3CloudPolicySample tests and setup should be
  refactored to not use 'admin_domain' and instead rely on actual domain
  ids created by keystone [0].

  [0]
  https://github.com/openstack/keystone/blob/ae87c03813fa0a1bfcd9d690817c8d45ee76fcb1/keystone/tests/unit/test_v3_protection.py#L608-L609

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1533330/+subscriptions