yahoo-eng-team team mailing list archive

[Lance Bragstad <lbragstad@xxxxxxxxx>]

Public bug reported:

The IdentityTestv3CloudPolicySample test classes has it's own setup
method, similar to other test classes. The setup method for
IdentityTestv3CloudPolicySample loads in sample data that can be used
throughout the tests in the module.

However, the IdentityTestv3CloudPolicySample setup method creates a
domain in such a way that is incompatible with how domains are created
in real world deployments. Keystone doesn't allow admins to specify
domain_id on request, making it so keystone always issues uuid.hex
formatted id strings for domain ids. The only domain that is the
exception to this rule is the default domain id, which is specified in
keystone's configuration.

The IdentityTestv3CloudPolicySample tests and setup should be refactored
to not use 'admin_domain' and instead rely on actual domain ids created
by keystone [0].

[0]
https://github.com/openstack/keystone/blob/ae87c03813fa0a1bfcd9d690817c8d45ee76fcb1/keystone/tests/unit/test_v3_protection.py#L608-L609

** Affects: keystone
     Importance: Undecided
         Status: New


** Tags: low-hanging-fruit test-improvement

** Tags added: low-hanging-fruit test-improvement

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1533330

Title:
  Some protection test cases have incorrect domain id setup

Status in OpenStack Identity (keystone):
  New

Bug description:
  The IdentityTestv3CloudPolicySample test classes has it's own setup
  method, similar to other test classes. The setup method for
  IdentityTestv3CloudPolicySample loads in sample data that can be used
  throughout the tests in the module.

  However, the IdentityTestv3CloudPolicySample setup method creates a
  domain in such a way that is incompatible with how domains are created
  in real world deployments. Keystone doesn't allow admins to specify
  domain_id on request, making it so keystone always issues uuid.hex
  formatted id strings for domain ids. The only domain that is the
  exception to this rule is the default domain id, which is specified in
  keystone's configuration.

  The IdentityTestv3CloudPolicySample tests and setup should be
  refactored to not use 'admin_domain' and instead rely on actual domain
  ids created by keystone [0].

  [0]
  https://github.com/openstack/keystone/blob/ae87c03813fa0a1bfcd9d690817c8d45ee76fcb1/keystone/tests/unit/test_v3_protection.py#L608-L609

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1533330/+subscriptions