yahoo-eng-team team mailing list archive

[OpenStack Infra <1268480@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/264012
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d2a1d6fcb7e746a5340db0990a8f5d0fc786738d
Submitter: Jenkins
Branch:    master

commit d2a1d6fcb7e746a5340db0990a8f5d0fc786738d
Author: lzklibj <lzklibj@xxxxxxxxxx>
Date:   Wed Jan 6 11:27:34 2016 +0800

    Unify using assertIsInstance
    
    Use assertIsInstance(A, B) to replace assertTrue(isinstance(A, B)).
    
    Prefer specific assertions such as assert(Not)IsInstance over generic ones
    (assertTrue/False, assertEqual) because they raise more meaningful errors.
    
    Change-Id: I56278b1a74108e2765a8a740658f33954f5404c7
    Closes-bug: #1268480


** Changed in: neutron
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in Barbican:
  In Progress
Status in Ceilometer:
  Fix Released
Status in Cinder:
  In Progress
Status in CloudRoast:
  In Progress
Status in congress:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in Ironic:
  Fix Released
Status in ironic-python-agent:
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in Monasca:
  Fix Released
Status in Murano:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-ironicclient:
  Fix Released
Status in python-keystoneclient:
  Fix Released
Status in python-manilaclient:
  In Progress
Status in python-novaclient:
  Fix Released
Status in OpenStack SDK:
  Fix Released
Status in python-tuskarclient:
  In Progress
Status in Rally:
  In Progress
Status in Sahara:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  In Progress
Status in Trove:
  Fix Released

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/barbican/+bug/1268480/+subscriptions