← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1527257] Re: Horizon shows key-pair name instead of ID

 

Reviewed:  https://review.openstack.org/259093
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=6164cd2f45fd9eb99ad53203015f10b03e0b84a5
Submitter: Jenkins
Branch:    master

commit 6164cd2f45fd9eb99ad53203015f10b03e0b84a5
Author: Paul Karikh <pkarikh@xxxxxxxxxxxx>
Date:   Thu Dec 17 19:09:27 2015 +0300

    Remove keypair ID from details table
    
    Currently Horizon shows keypdair.id in
    project->compute->access&security->keypairs
    -> keypair details tab.
    But python-novaclient always returns
    keypair.id=keypair.name.
    
    Right now Nova sends ID in its response and python-novaclient got it,
    but python-novaclient does not pass that ID into the Horizon.
    And keypair-id is also shown via nova-cli.
    But Nova folks says that ID is a some kind of private atrtr in Nova,
    and that fact it is shown via cli is a side-effect and should be fiexed.
    
    So, Horizon should not use keypair-id and this patch removes it.
    
    Change-Id: Idd13b8900342fb98675fc8c98fff016109d8161b
    Closes-Bug: #1527257


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1527257

Title:
  Horizon shows key-pair name instead of ID

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  Navigate to Project -> Compute -> Access & Security -> Key Pairs tab
  Create a keypair.
  Keypair details will show keypair name instead of ID.

  According to Compute API docs - http://developer.openstack.org/api-
  ref-compute-v2.1.html#keypairs-v2.1 - IDs are not exposed via API and
  a keypair name is used to uniquely identify a resource.

  And according to nova-folks the fact that id` attribute is printed by
  python-cli is a side-effect and users of Nova API must not use keypair
  IDs and see it anywhere.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1527257/+subscriptions


References