← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1277104] Re: wrong order of assertEquals args

 

Reviewed:  https://review.openstack.org/264029
Committed: https://git.openstack.org/cgit/openstack/python-solumclient/commit/?id=6559731fb33bddccb364ab8430f6b41b1447f76f
Submitter: Jenkins
Branch:    master

commit 6559731fb33bddccb364ab8430f6b41b1447f76f
Author: reedip <reedip.banerjee@xxxxxxxxxxxxxxxxxx>
Date:   Wed Jan 6 14:38:55 2016 +0900

    Fix argument order for assertEqual to (expected, observed)
    
    assertEqual expects that the arguments provided to it should be (expected, observed).
    If a particluar order is kept as a convention, then it helps to provide a cleaner
    message to the developer if Unit Tests fail.
    The following patch fixes this issue
    
    TrivialFix
    
    Change-Id: I164dd6b2b820e4ca26bf3406f591ca786893f279
    Closes-Bug: #1259292
    Closes-Bug: #1277104


** Changed in: python-solumclient
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1277104

Title:
  wrong order of assertEquals args

Status in Ceilometer:
  Fix Released
Status in Cinder:
  Fix Released
Status in Glance:
  Fix Released
Status in ironic-python-agent:
  Fix Released
Status in OpenStack Identity (keystone):
  Fix Released
Status in Manila:
  In Progress
Status in neutron:
  Fix Released
Status in oslo.messaging:
  Fix Released
Status in oslo.policy:
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-ironicclient:
  Fix Released
Status in python-novaclient:
  Fix Released
Status in python-openstackclient:
  Fix Released
Status in Python client library for Sahara:
  Fix Released
Status in python-solumclient:
  Fix Released
Status in python-swiftclient:
  Won't Fix
Status in python-troveclient:
  Fix Released
Status in Rally:
  Confirmed
Status in Trove:
  Fix Released

Bug description:
  Args of assertEquals method in ceilometer.tests are arranged in wrong order. In result when test fails it shows incorrect information about observed and actual data. It's found more than 2000 times.
  Right order of arguments is "expected, actual".

To manage notifications about this bug go to:
https://bugs.launchpad.net/ceilometer/+bug/1277104/+subscriptions