yahoo-eng-team team mailing list archive

Thread
Date

[Bug 1259292] Re: Some tests use assertEqual(observed, expected) , the argument order is wrong

To: yahoo-eng-team@xxxxxxxxxxxxxxxxxxx
From: OpenStack Infra <1259292@xxxxxxxxxxxxxxxxxx>
Date: Wed, 20 Jan 2016 16:04:45 -0000
Reply-to: Bug 1259292 <1259292@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx

Reviewed:  https://review.openstack.org/264029
Committed: https://git.openstack.org/cgit/openstack/python-solumclient/commit/?id=6559731fb33bddccb364ab8430f6b41b1447f76f
Submitter: Jenkins
Branch:    master

commit 6559731fb33bddccb364ab8430f6b41b1447f76f
Author: reedip <reedip.banerjee@xxxxxxxxxxxxxxxxxx>
Date:   Wed Jan 6 14:38:55 2016 +0900

    Fix argument order for assertEqual to (expected, observed)
    
    assertEqual expects that the arguments provided to it should be (expected, observed).
    If a particluar order is kept as a convention, then it helps to provide a cleaner
    message to the developer if Unit Tests fail.
    The following patch fixes this issue
    
    TrivialFix
    
    Change-Id: I164dd6b2b820e4ca26bf3406f591ca786893f279
    Closes-Bug: #1259292
    Closes-Bug: #1277104


** Changed in: python-solumclient
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1259292

Title:
  Some tests use assertEqual(observed, expected) , the argument order is
  wrong

Status in Barbican:
  In Progress
Status in Ceilometer:
  Invalid
Status in Cinder:
  Fix Released
Status in congress:
  In Progress
Status in Designate:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Magnum:
  Fix Released
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in Murano:
  Fix Released
Status in OpenStack Compute (nova):
  Won't Fix
Status in python-ceilometerclient:
  Invalid
Status in python-cinderclient:
  Fix Released
Status in python-designateclient:
  Fix Committed
Status in python-mistralclient:
  Fix Released
Status in python-solumclient:
  Fix Released
Status in Python client library for Zaqar:
  Fix Released
Status in Sahara:
  Fix Released
Status in zaqar:
  Fix Released

Bug description:
  The test cases will produce a confusing error message if the tests
  ever fail, so this is worth fixing.

To manage notifications about this bug go to:
https://bugs.launchpad.net/barbican/+bug/1259292/+subscriptions