← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1518584] Re: Branding: Horizon Header should be more composable

 

Reviewed:  https://review.openstack.org/248394
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=378623217deb434a067fffb1fcf83e3520ffda33
Submitter: Jenkins
Branch:    master

commit 378623217deb434a067fffb1fcf83e3520ffda33
Author: Diana Whitten <hurgleburgler@xxxxxxxxx>
Date:   Mon Dec 14 14:42:35 2015 -0700

    Branding: Horizon Header should be more composable
    
    A recent branding effort exposed several aspects of the header
    templates that need to be more composable to enable richer
    customizations.
    
    The Horizon _header.html template has many components within it:
    region pickers, user menus, logos. All of these things are highly
    desirable to customize, but because it is all contained in the same
    template, a brander will have to override the entire template. This
    is not ideal as it increase the cost of maintenance.
    
    The splash section of the login page, the context selector, the logo
    section of the header, the user menu and the region selector are now
    composable to a much more granular level.  The top navigation menus
    can now be used outside of existing within a list.  The templates
    now allow use as normal, standalone dropdown items.
    
    Also, the current primary color used for 'material' was highly
    unpleasant with OpenStack Red.  Another color on the material design
    palette was chosen, very close to the previous blue. See
    https://www.google.com/design/spec/style/color.html#color-color-palette
    
    To showcase this new composability, 'material' now shows how to
    customize the logo and logo-splash beyond just replacing the png, but
    now allowing the use of any type of image.  In this case, the
    OpenStack logos have been upgraded with their svg counterparts.
    
    It was also noted that the context selection menu was using the wrong
    variable to set the color of its links. This was corrected.
    
    Closes-Bug: #1518584
    
    Change-Id: Ib544176b9836e17fc913170664646e1d10eda831


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1518584

Title:
  Branding: Horizon Header should be more composable

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The Horizon _header.html template has many components within it:
  region pickers, user menus, logos.  All of these things are highly
  desirable to customize, but because it is all contained in the same
  template, a brander will have to override the entire template.  This
  is not ideal as it increase the cost of maintenance.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1518584/+subscriptions


References