yahoo-eng-team team mailing list archive

[OpenStack Infra <1268480@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/262539
Committed: https://git.openstack.org/cgit/openstack/barbican/commit/?id=fb1e2317651febf67f27298b61511f3e6b8c9a62
Submitter: Jenkins
Branch:    master

commit fb1e2317651febf67f27298b61511f3e6b8c9a62
Author: Shuquan Huang <huang.shuquan@xxxxxxxxxxx>
Date:   Wed Dec 30 23:04:48 2015 +0800

    Change assertTrue(isinstance()) by optimal assert
    
    Some of tests use different method of assertTrue(isinstance(A, B)) or
    assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
    B) provided by testtools.
    
    Change-Id: I3424d529c568f0a9570a757cc6e85155b0645d4b
    Closes-bug: #1268480


** Changed in: barbican
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to anvil.
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in anvil:
  In Progress
Status in Barbican:
  Fix Released
Status in Ceilometer:
  Fix Released
Status in Cinder:
  In Progress
Status in CloudRoast:
  In Progress
Status in congress:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in ironic-python-agent:
  In Progress
Status in OpenStack Identity (keystone):
  Fix Released
Status in Magnum:
  In Progress
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in Monasca:
  Fix Released
Status in Murano:
  Fix Released
Status in networking-powervm:
  In Progress
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-heatclient:
  In Progress
Status in python-keystoneclient:
  Fix Released
Status in python-manilaclient:
  In Progress
Status in python-novaclient:
  Fix Released
Status in python-openstackclient:
  In Progress
Status in OpenStack SDK:
  Fix Released
Status in python-rackclient:
  In Progress
Status in python-tuskarclient:
  In Progress
Status in Rally:
  In Progress
Status in Sahara:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  In Progress
Status in Trove:
  Fix Released
Status in tuskar:
  In Progress

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/anvil/+bug/1268480/+subscriptions