yahoo-eng-team team mailing list archive

[OpenStack Infra <1268480@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/262529
Committed: https://git.openstack.org/cgit/openstack/ironic-python-agent/commit/?id=fac700c8e76919996b735a5a3760050bfe05e88c
Submitter: Jenkins
Branch:    master

commit fac700c8e76919996b735a5a3760050bfe05e88c
Author: Shuquan Huang <huang.shuquan@xxxxxxxxxxx>
Date:   Wed Dec 30 22:38:25 2015 +0800

    Change assertTrue(isinstance()) by optimal assert
    
    Some of tests use different method of assertTrue(isinstance(A, B)) or
    assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
    B) provided by testtools.
    
    Change-Id: I8e95e10fac4748b115838b6b480f1085da73f28a
    Closes-bug: #1268480


** Changed in: ironic-python-agent
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to anvil.
https://bugs.launchpad.net/bugs/1268480

Title:
  assertTrue(isinstance()) in tests should be replace with
  assertIsInstance()

Status in anvil:
  In Progress
Status in Barbican:
  Fix Released
Status in Ceilometer:
  Fix Released
Status in Cinder:
  In Progress
Status in CloudRoast:
  In Progress
Status in congress:
  Fix Released
Status in Glance:
  Fix Released
Status in heat:
  Fix Released
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in ironic-python-agent:
  Fix Released
Status in OpenStack Identity (keystone):
  Fix Released
Status in Magnum:
  In Progress
Status in Manila:
  Fix Released
Status in Mistral:
  Fix Released
Status in Monasca:
  Fix Released
Status in Murano:
  Fix Released
Status in networking-powervm:
  In Progress
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Fix Released
Status in python-ceilometerclient:
  Fix Released
Status in python-cinderclient:
  Fix Released
Status in python-glanceclient:
  Fix Released
Status in python-heatclient:
  In Progress
Status in python-keystoneclient:
  Fix Released
Status in python-manilaclient:
  In Progress
Status in python-novaclient:
  Fix Released
Status in python-openstackclient:
  In Progress
Status in OpenStack SDK:
  Fix Released
Status in python-rackclient:
  In Progress
Status in python-tuskarclient:
  In Progress
Status in Rally:
  In Progress
Status in Sahara:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  In Progress
Status in Trove:
  Fix Released
Status in tuskar:
  In Progress

Bug description:
  some of tests use different method of assertTrue(isinstance(A, B)) or
  assertEqual(type(A), B). The correct way is to use assertIsInstance(A,
  B) provided by testtools

To manage notifications about this bug go to:
https://bugs.launchpad.net/anvil/+bug/1268480/+subscriptions