yahoo-eng-team team mailing list archive

[OpenStack Infra <1456493@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/189958
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=a54f10a0c2fd5f8c3e5d0068eb8b830d34fa9b63
Submitter: Jenkins
Branch:    master

commit a54f10a0c2fd5f8c3e5d0068eb8b830d34fa9b63
Author: karimb <karimboumedhel@xxxxxxxxx>
Date:   Wed Jun 10 00:09:51 2015 +0200

    Fix misleading comment of pci_stats
    
    make sure the comment around pci_stats reports the correct type for this variable
    
    Change-Id: I889c0b3cf84685f529ec0ef6062b4ec658ff8269
    Closes-Bug: 1456493


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1456493

Title:
  the comment of pci_stats is misleading

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  Version: Juno 2014.2.1
  In nova/db/sqlalchemy/Models.py,  there is a variable pci_stats in class ComputeNode

      # Note(yongli): json string PCI Stats
      # '{"vendor_id":"8086", "product_id":"1234", "count":3 }'
      pci_stats = Column(Text)
  In fact,  the type of pci_stats is not  dict.  the type is list.

  so I suggect modification as follow 
      # Note(yongli): json string PCI Stats
      # '[{"vendor_id":"8086", "product_id":"1234", "count":3 }, ...]'
      pci_stats = Column(Text)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1456493/+subscriptions