← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1456493] [NEW] the comment of pci_stats is misleading

 

Public bug reported:

Version: Juno 2014.2.1
In nova/db/sqlalchemy/Models.py,  there is a variable pci_stats in class ComputeNode

    # Note(yongli): json string PCI Stats
    # '{"vendor_id":"8086", "product_id":"1234", "count":3 }'
    pci_stats = Column(Text)
In fact,  the type of pci_stats is not  dict.  the type is list.

so I suggect modification as follow 
    # Note(yongli): json string PCI Stats
    # '[{"vendor_id":"8086", "product_id":"1234", "count":3 }, ...]'
    pci_stats = Column(Text)

** Affects: nova
     Importance: Undecided
     Assignee: xhzhf (guoyongxhzhf)
         Status: New

** Changed in: nova
     Assignee: (unassigned) => xhzhf (guoyongxhzhf)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1456493

Title:
  the comment of pci_stats is misleading

Status in OpenStack Compute (Nova):
  New

Bug description:
  Version: Juno 2014.2.1
  In nova/db/sqlalchemy/Models.py,  there is a variable pci_stats in class ComputeNode

      # Note(yongli): json string PCI Stats
      # '{"vendor_id":"8086", "product_id":"1234", "count":3 }'
      pci_stats = Column(Text)
  In fact,  the type of pci_stats is not  dict.  the type is list.

  so I suggect modification as follow 
      # Note(yongli): json string PCI Stats
      # '[{"vendor_id":"8086", "product_id":"1234", "count":3 }, ...]'
      pci_stats = Column(Text)

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1456493/+subscriptions


Follow ups

References