← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1525309] Re: action_present and action_past attributes have to be deprecated in favor of action_present and action_past methods

 

Reviewed:  https://review.openstack.org/256567
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b313c4c40daeeb3cc141b36fcf28b2aa7ec496d5
Submitter: Jenkins
Branch:    master

commit b313c4c40daeeb3cc141b36fcf28b2aa7ec496d5
Author: Yves-Gwenael Bourhis <yves-gwenael.bourhis@xxxxxxxxxxxxx>
Date:   Fri Dec 11 17:19:47 2015 +0100

    Changed to DeprecationWarning in BatchAction.
    
    BatchAction class was triggering a PendingDeprecationWarning
    We now have to trigger a DeprecationWarning to ensure new code does not come
    with the old attribute style of action_present and action_past.
    
    Change-Id: I3c4b212d6a42cdf7466d1df5a74d679349bf9e9a
    Closes-Bug: #1525309


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1525309

Title:
  action_present and action_past attributes have to be deprecated in
  favor of action_present and action_past methods

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  actions.BatchAction subclasses need to use action_present and action_past methodes and triger a deprecation warning when using attributes
  If we don't do so, attributes will ever come back and are not translatable.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1525309/+subscriptions


References