← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1540254] Re: "#flake8: noqa" is using incorrectly

 

Reviewed:  https://review.openstack.org/274637
Committed: https://git.openstack.org/cgit/openstack/python-novaclient/commit/?id=0105fd120659baf3445b994af29837755d155c73
Submitter: Jenkins
Branch:    master

commit 0105fd120659baf3445b994af29837755d155c73
Author: Bo Wang <bo.wang@xxxxxxxxxxxx>
Date:   Mon Feb 1 20:17:47 2016 +0800

    Use # noqa to ignore one line but not whole file
    
    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".
    
    Closes Bug: #1540254
    
    Change-Id: I34c8a2218f974cd7e78c60e9c1fec26751c4e82d


** Changed in: python-novaclient
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1540254

Title:
  "#flake8: noqa" is using incorrectly

Status in OpenStack Dashboard (Horizon):
  In Progress
Status in python-heatclient:
  Fix Released
Status in python-novaclient:
  Fix Released

Bug description:
  "# flake8: noqa" option disables all checks for the whole file. To
  disable one line we should use "# noqa".

  Refer to: https://pypi.python.org/pypi/flake8
  https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1540254/+subscriptions


References