← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1540254] Re: "#flake8: noqa" is using incorrectly

 

Reviewed:  https://review.openstack.org/274548
Committed: https://git.openstack.org/cgit/openstack/python-heatclient/commit/?id=3298ad98c88309c0aab972284b2a403573224c94
Submitter: Jenkins
Branch:    master

commit 3298ad98c88309c0aab972284b2a403573224c94
Author: Bo Wang <bo.wang@xxxxxxxxxxxx>
Date:   Mon Feb 1 16:32:12 2016 +0800

    Remove incorrectly used "# flake8: noqa"
    
    "# flake8: noqa" option disables all checks for the whole file.
    To disable one line we should use "# noqa".
    Remove unused "# flake8: noqa" and fix hidden hacking errors.
    
    Change-Id: I624e96784ae7a22b5a5766f38bdf1fb8ade2d0a2
    Closes-Bug: #1540254


** Changed in: python-heatclient
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1540254

Title:
  "#flake8: noqa" is using incorrectly

Status in OpenStack Dashboard (Horizon):
  In Progress
Status in python-heatclient:
  Fix Released
Status in python-novaclient:
  In Progress

Bug description:
  "# flake8: noqa" option disables all checks for the whole file. To
  disable one line we should use "# noqa".

  Refer to: https://pypi.python.org/pypi/flake8
  https://github.com/openstack/python-keystoneclient/commit/3b766c51438396a0ab0032de309c9d56e275e0cb

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1540254/+subscriptions


References