← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1543541] Re: When an unhandled Python error is raised in i9n tests, cleanup code becomes non-functional

 

Reviewed:  https://review.openstack.org/277755
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=51f35099bc0be32e26012ace18b1eb4502690349
Submitter: Jenkins
Branch:    master

commit 51f35099bc0be32e26012ace18b1eb4502690349
Author: Timur Sufiev <tsufiev@xxxxxxxxxxxx>
Date:   Tue Feb 9 12:38:19 2016 +0300

    Don't overwrite original traceback in certain cases of i9n failures
    
    Achieve this by muffling exceptions (raised due to Selenium became not
    resposive) while taking integration test failure screenshot.
    
    Also extract the pattern of muffling and capturing exceptions common
    for dump_browser_log, dump_html_page and save_screenshot in a common
    @exceptions_captured context manager.
    
    Closes-Bug: #1543541
    Change-Id: I37fa18a302c553b43529df056d2beacff70f6189


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1543541

Title:
  When an unhandled Python error is raised in i9n tests, cleanup code
  becomes non-functional

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  What's worse, the call which should take a screenshot raises another
  exception (since Selenium is no longer responding after that unhandled
  error has been raised) which completely overwrites the original
  exception and traceback. And without original traceback it's very
  difficult to understand what caused integration test to fail.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1543541/+subscriptions


References