← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1537526] Re: Integration tests @tables.bind_row_action() is too picky about buttons layout

 

Reviewed:  https://review.openstack.org/271805
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=4b83421bf58e4a94c7b449b1f51f4512bfaf81b7
Submitter: Jenkins
Branch:    master

commit 4b83421bf58e4a94c7b449b1f51f4512bfaf81b7
Author: Timur Sufiev <tsufiev@xxxxxxxxxxxx>
Date:   Sun Jan 24 21:12:23 2016 +0300

    Allow @tables.bind_row_action() to bind in 2 additional scenarios
    
    First, it's now able to bind destructive actions rendered with
    button.btn-dander. Second, now it successfully matches a single
    primary action (button outside of div.btn-group container).
    
    Change-Id: I1c55dc10b344c4899a80d83f4d18e59d5df266a6
    Closes-Bug: #1537526


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1537526

Title:
  Integration tests @tables.bind_row_action() is too picky about buttons
  layout

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  First, it cannot bind action to the button with destructive effects
  (marked with .btn-danger), which is rendered as <button> element
  instead of <a>. Second, @bind_row_action() decorator doesn't expect to
  find a single primary action, outside of div.btn-group container -
  thus failing to click the single button.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1537526/+subscriptions


References