yahoo-eng-team team mailing list archive

[Kairat Kushaev <kkushaev@xxxxxxxxxxxx>]

Public bug reported:

Glance uses custom function to search endpoint in service catalog:
https://github.com/openstack/glance/blob/master/glance/common/auth.py#L259
But that functionality is also available in python-keystoneclient:
https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/service_catalog.py#L352
So we can reduce code duplication and just simply use the logic from keystoneclient to search endpoint.

P.S. Looks like we need to initialize ServiceCatalog in request context.
It looks like we need separate attribute for ServiceCatalog(and
deprecate current attribute in request context) so need some additional
work.

** Affects: glance
     Importance: Undecided
     Assignee: Kairat Kushaev (kkushaev)
         Status: In Progress

** Changed in: glance
     Assignee: (unassigned) => Kairat Kushaev (kkushaev)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1544469

Title:
  Use Keystone Service catalog to search endpoints

Status in Glance:
  In Progress

Bug description:
  Glance uses custom function to search endpoint in service catalog:
  https://github.com/openstack/glance/blob/master/glance/common/auth.py#L259
  But that functionality is also available in python-keystoneclient:
  https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/service_catalog.py#L352
  So we can reduce code duplication and just simply use the logic from keystoneclient to search endpoint.

  P.S. Looks like we need to initialize ServiceCatalog in request
  context. It looks like we need separate attribute for
  ServiceCatalog(and deprecate current attribute in request context) so
  need some additional work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1544469/+subscriptions