yahoo-eng-team team mailing list archive

[OpenStack Infra <1544469@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/274131
Committed: https://git.openstack.org/cgit/openstack/glance/commit/?id=5062e1bb50b1bbae5f56e2f82f96e6484c12e824
Submitter: Jenkins
Branch:    master

commit 5062e1bb50b1bbae5f56e2f82f96e6484c12e824
Author: kairat_kushaev <kkushaev@xxxxxxxxxxxx>
Date:   Fri Jan 29 18:53:30 2016 +0300

    Use keystoneclient functions to receive endpoint
    
    Use keystoneclient function get_urls from service catalog to
    search glance endpoints. So the search logic will be defined
    in keystone and glance only works with received endpoints.
    
    Closes-Bug: #1544469
    Change-Id: I4b1e92647e594d564005d54e9eec692df32f5980


** Changed in: glance
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Glance.
https://bugs.launchpad.net/bugs/1544469

Title:
  Use Keystone Service catalog to search endpoints

Status in Glance:
  Fix Released

Bug description:
  Glance uses custom function to search endpoint in service catalog:
  https://github.com/openstack/glance/blob/master/glance/common/auth.py#L259
  But that functionality is also available in python-keystoneclient:
  https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/service_catalog.py#L352
  So we can reduce code duplication and just simply use the logic from keystoneclient to search endpoint.

  P.S. Looks like we need to initialize ServiceCatalog in request
  context. It looks like we need separate attribute for
  ServiceCatalog(and deprecate current attribute in request context) so
  need some additional work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/glance/+bug/1544469/+subscriptions