yahoo-eng-team team mailing list archive

[Thai Tran <tqtran@xxxxxxxxxx>]

Public bug reported:

Hz-table-controller currently returns a map of items that were
checked/unchecked. We then have to manually filter through this list to
get the selected items. To make matters more confusing, this map is
wrongly called selected.

Misleading 'selected' property: https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/table/table.controller.js#L34
Manually filtering example: https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/actions/batch-delete.service.js#L77

** Affects: horizon
     Importance: Medium
     Assignee: Thai Tran (tqtran)
         Status: New

** Description changed:

  Hz-table-controller currently returns a map of items that were
  checked/unchecked. We then have to manually filter through this list to
- get the selected items. To make matters worse, this map is wrongly
- called selected.
+ get the selected items. To make matters more confusing, this map is
+ wrongly called selected.
+ 
+ Misleading 'selected' property: https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/table/table.controller.js#L34
+ Manually filtering example: https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/actions/batch-delete.service.js#L77

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1545861

Title:
  Hz-table-controller should return only selected items

Status in OpenStack Dashboard (Horizon):
  New

Bug description:
  Hz-table-controller currently returns a map of items that were
  checked/unchecked. We then have to manually filter through this list
  to get the selected items. To make matters more confusing, this map is
  wrongly called selected.

  Misleading 'selected' property: https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/table/table.controller.js#L34
  Manually filtering example: https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/actions/batch-delete.service.js#L77

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1545861/+subscriptions