yahoo-eng-team team mailing list archive

[OpenStack Infra <1545370@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/279909
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=1fd0f4f69b21cbd20c0eb0e2f8f4506061f4a211
Submitter: Jenkins
Branch:    master

commit 1fd0f4f69b21cbd20c0eb0e2f8f4506061f4a211
Author: Davanum Srinivas <davanum@xxxxxxxxx>
Date:   Sat Feb 13 21:22:54 2016 -0500

    Tolerate installation of pycryptodome
    
    Newer versions of pysaml2 uses pycryptodome, so if by
    accident if this library gets installed, Nova breaks.
    
    paramiko folks are working on this:
    https://github.com/paramiko/paramiko/issues/637
    
    In the meanwhile, we should tolerate if either pycrypto
    or pycryptodome is installed.
    
    Closes-Bug: #1545370
    Change-Id: If88beeb3983705621fe736995939ac20b2daf1f3


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1545370

Title:
  pycryptodome breaks nova/barbican/glance/kite

Status in Barbican:
  New
Status in Glance:
  New
Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  pysaml2===4.0.3 drags in pycryptodome===3.4 which breaks Nova in the
  both unit tests and grenade.

  nova.tests.unit.test_crypto.KeyPairTest.test_generate_key_pair_1024_bits
  ------------------------------------------------------------------------

  Captured traceback:
  ~~~~~~~~~~~~~~~~~~~
      Traceback (most recent call last):
        File "nova/tests/unit/test_crypto.py", line 352, in test_generate_key_pair_1024_bits
          (private_key, public_key, fingerprint) = crypto.generate_key_pair(bits)
        File "nova/crypto.py", line 165, in generate_key_pair
          key = paramiko.RSAKey.generate(bits)
        File "/Users/dims/openstack/openstack/nova/.tox/py27/lib/python2.7/site-packages/paramiko/rsakey.py", line 146, in generate
          rsa = RSA.generate(bits, os.urandom, progress_func)
        File "/Users/dims/openstack/openstack/nova/.tox/py27/lib/python2.7/site-packages/Crypto/PublicKey/RSA.py", line 436, in generate
          if e % 2 == 0 or e < 3:
      TypeError: unsupported operand type(s) for %: 'NoneType' and 'int'

To manage notifications about this bug go to:
https://bugs.launchpad.net/barbican/+bug/1545370/+subscriptions