← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1545814] Re: Tablecontroller should use ctrl instead of scope

 

Reviewed:  https://review.openstack.org/280365
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=b01ceda1edbb536867db0d55ad95e3666a1b5b4b
Submitter: Jenkins
Branch:    master

commit b01ceda1edbb536867db0d55ad95e3666a1b5b4b
Author: Thai Tran <tqtran@xxxxxxxxxx>
Date:   Thu Feb 18 11:36:15 2016 -0800

    Tablecontroller should use ctrl instead of scope
    
    TableController currently uses $scope for selected and numSelected.
    It should use ctrl as suggested by JP's guide.
    
    Change-Id: Ie0bdd85343206008ba80fb6a696c78bfc7fe09bb
    Closes-Bug: #1545814


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1545814

Title:
  Tablecontroller should use ctrl instead of scope

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  horizon.framework.widgets.table.controller:TableController currently
  uses $scope for selected and numSelected. It should use ctrl as
  suggested by JP's guide.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1545814/+subscriptions


References