yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #46710
[Bug 1463727] Re: base64.urlsafe_b64encode returns unexpected type in python3
fixed by
https://github.com/openstack/keystone/commit/7e0c6a9e2c418c44817991364fc18a7a2834eebe
** Changed in: keystone
Status: Triaged => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Identity (keystone).
https://bugs.launchpad.net/bugs/1463727
Title:
base64.urlsafe_b64encode returns unexpected type in python3
Status in OpenStack Identity (keystone):
Fix Released
Bug description:
In the testcase of
test_v3_token_data_helper_populate_audit_info_string [1], we generate
audit_info via base64.urlsafe_b64encode, the value returned is a
string, acutally, the audit_info should be unicode instead of a string
type.
This will hide some issues while the testcase should detect [2]
instead of simply pass the test.
[1] https://github.com/openstack/keystone/blob/2bb4593266a5905679b5a4b3e0058383fbb9c1c5/keystone/tests/unit/token/test_token_data_helper.py#L31
[2] https://review.openstack.org/#/c/125410/11/keystone/token/providers/common.py
To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1463727/+subscriptions
References