yahoo-eng-team team mailing list archive

[Dave Chen <wei.d.chen@xxxxxxxxx>]

Public bug reported:

In the testcase of test_v3_token_data_helper_populate_audit_info_string
[1], we generate audit_info via base64.urlsafe_b64encode, the value
returned is a string, acutally, the audit_info should be unicode instead
of a string type.

This will hide some issues while the testcase should detect [2] instead
of simply pass the test.


[1] https://github.com/openstack/keystone/blob/master/keystone/tests/unit/token/test_token_data_helper.py#L31
[2] https://review.openstack.org/#/c/125410/11/keystone/token/providers/common.py

** Affects: keystone
     Importance: Undecided
     Assignee: Dave Chen (wei-d-chen)
         Status: New

** Changed in: keystone
     Assignee: (unassigned) => Dave Chen (wei-d-chen)

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to Keystone.
https://bugs.launchpad.net/bugs/1463727

Title:
  unicode is not string

Status in OpenStack Identity (Keystone):
  New

Bug description:
  In the testcase of
  test_v3_token_data_helper_populate_audit_info_string [1], we generate
  audit_info via base64.urlsafe_b64encode, the value returned is a
  string, acutally, the audit_info should be unicode instead of a string
  type.

  This will hide some issues while the testcase should detect [2]
  instead of simply pass the test.


  [1] https://github.com/openstack/keystone/blob/master/keystone/tests/unit/token/test_token_data_helper.py#L31
  [2] https://review.openstack.org/#/c/125410/11/keystone/token/providers/common.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/keystone/+bug/1463727/+subscriptions