yahoo-eng-team team mailing list archive

[OpenStack Infra <1547279@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/282148
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=519f4560a845a998333228c23d7b7866b9a67a3b
Submitter: Jenkins
Branch:    master

commit 519f4560a845a998333228c23d7b7866b9a67a3b
Author: Matt Riedemann <mriedem@xxxxxxxxxx>
Date:   Thu Feb 18 19:05:30 2016 -0800

    Fixed leaked UnexpectedMethodCallErrors in test_compute
    
    Both of these tests were actually leaking UnexpectedMethodCallErrors
    from mox due to the allocate_for_instance call being stubbed out
    but the kwargs were in the wrong order.
    
    Apparently something with mox, the stub_out fixture, and
    NetworkInfoAsyncWrapper using nova.utils.spawn cause the stubs
    to be on a greenthread so when mox raises the error, it doesn't
    fail the actual test, it just gets logged to stderr by eventlet.
    
    In the case of the test_run_instance_queries_macs test, this was
    actually causing the test to run over a minute (presumably because
    it would eventually hit some timeout in the thread, like an rpc
    timeout maybe?). With this fix it drops that down to around 1 second
    to run the test.
    
    We really need to figure out what's causing the stub to go on the
    thread so that the test doesn't get the UnexpectedMethodCallError
    and fail but that could come in a later change if someone can
    figure it out.
    
    Change-Id: Ibc5c881e17310304eb63f5df6360f8cb1657b807
    Closes-Bug: #1547279


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1547279

Title:
  nova.tests.unit.compute.test_compute.ComputeTestCase.test_run_instance_queries_macs
  takes an average of 1 minute to run

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  http://status.openstack.org//openstack-health/#/job/gate-nova-
  python27?groupKey=project&resolutionKey=hour&duration=P1M shows that
  the
  nova.tests.unit.compute.test_compute.ComputeTestCase.test_run_instance_queries_macs
  unit test is taking around 1 minute to run.  It looks like most things
  should be stubbed out properly in that test so I'm not sure what's
  causing the holdup.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1547279/+subscriptions