← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1546758] Re: Inconsistent ordering for angular table actions

 

Reviewed:  https://review.openstack.org/281531
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=e3c31b9b6a33d8785dc306d4a268fad164c1cdde
Submitter: Jenkins
Branch:    master

commit e3c31b9b6a33d8785dc306d4a268fad164c1cdde
Author: Justin Pomeroy <jpomero@xxxxxxxxxxxxxxxxxx>
Date:   Wed Feb 17 15:14:49 2016 -0600

    Maintain order when resolving promise list
    
    This updates the $qExtensions.allSettled method so that it maintains
    the order of the original list of promises. The list of passed and
    failed promises will be in the same order as they were in the
    original list.
    
    Closes-Bug: #1546758
    Change-Id: I9de0b68a16c4f3e2a9a34fb8862de2d77b4a19bb


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1546758

Title:
  Inconsistent ordering for angular table actions

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The horizon angular actions service uses $qExtensions.allSettled when
  resolving permitted actions.  The allSettled method does not enforce
  that the order of the pass and fail promise arrays are the same as the
  original list of promises, and this can cause the order of the actions
  to be inconsistent.  The order of the actions is actually determined
  by the order in which they are resolved.  This causes actions I want
  to be last in the menu (Delete) to sometimes show up as the default
  button action.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1546758/+subscriptions


References