← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1497057] Re: DB filtering applies REGEX to non-string columns

 

The current code seems to be working fine, closing as Opinion. Fixes
here are fine but this isn't really an issue we're going to track to
completion.

** Changed in: nova
       Status: New => Opinion

** Changed in: nova
   Importance: Undecided => Wishlist

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1497057

Title:
  DB filtering applies REGEX to non-string columns

Status in OpenStack Compute (nova):
  Opinion

Bug description:
  While writing the patch https://review.openstack.org/#/c/224431/ I
  noticed that a separate test failed if I did not str() the filter
  values. The failing test is
  nova.tests.unit.compute.test_compute.ComputeAPITestCase.test_get_all_by_state
  and I'll attach the output, but it is also at this test output URL:

  http://logs.openstack.org/31/224431/1/check/gate-nova-python27/41a4c00/console.html#_2015-09-17_05_47_20_844
  (also at http://paste.openstack.org/show/467079/)

  The code is in nova/db/sqlalchemy/api.py in the _regex_instance_filter
  function.  It would make sense to move non-string columns off to a
  separate filter, rather than applying a REGEX to them.

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1497057/+subscriptions


References