← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1548198] Re: Misuse of assertTrue in console and virt unittests

 

Reviewed:  https://review.openstack.org/282983
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=ca2c7a89849a6223ac9c4dd79ccdb6da86e0a7d2
Submitter: Jenkins
Branch:    master

commit ca2c7a89849a6223ac9c4dd79ccdb6da86e0a7d2
Author: Takashi NATSUME <natsume.takashi@xxxxxxxxxxxxx>
Date:   Mon Feb 22 15:50:29 2016 +0900

    Fix misuse of assertTrue in console and virt tests
    
    AssertEqual should be used instead of assertTrue in the unit tests.
    
    Change-Id: I7d196443e771090c7d9dd2c19bab237146e20e10
    Closes-Bug: #1548198


** Changed in: nova
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1548198

Title:
  Misuse of assertTrue in console and virt unittests

Status in OpenStack Compute (nova):
  Fix Released

Bug description:
  AssertEqual should be used instead of assertTrue in the following
  unitetests.

  test_get_format_fs method of class VirtDiskVFSGuestFSTestin nova/tests/unit/console/test_serial.py
  test_acquire_port method of class VirtDiskVFSGuestFSTest in nova/tests/unit/virt/disk/vfs/test_guestfs.py
  test_get_os method of class LibvirtOsInfoTest in nova/tests/unit/virt/test_osinfo.py

To manage notifications about this bug go to:
https://bugs.launchpad.net/nova/+bug/1548198/+subscriptions


References