yahoo-eng-team team mailing list archive

[OpenStack Infra <1549924@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/284857
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=2c5fbbfe5b0cf129ba71757c0234d56e30fafb59
Submitter: Jenkins
Branch:    master

commit 2c5fbbfe5b0cf129ba71757c0234d56e30fafb59
Author: Cindy Lu <clu@xxxxxxxxxx>
Date:   Thu Feb 25 10:11:52 2016 -0800

    Fix test cases that have no expectations
    
    Fixed 2 unit tests that were not testing anything (you can see this in the
    localhost:8001/jasmine/ console).
    
    Change-Id: I023029b8eb190a1b5687de80e54a725c38b43fe6
    Closes-Bug: #1549924


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1549924

Title:
  fix 2 unit tests that do not have expectations

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  See localhost:8001/jasmine/ console to see that there are two unit
  tests that do not set any expectations and essentially do not test
  anything:

  Spec 'MagiSearchController keypress handler opens menu when searchVal
  is a space' has no expectations.

  Spec 'Launch Instance Keypair Step Import Key Pair Controller
  successful submit calls the successCallback' has no expectations.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1549924/+subscriptions