yahoo-eng-team team mailing list archive

[OpenStack Infra <1553610@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/289328
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=db63b9e0264df6029600b34f199767302d7c7353
Submitter: Jenkins
Branch:    master

commit db63b9e0264df6029600b34f199767302d7c7353
Author: Rob Cresswell <robert.cresswell@xxxxxxxxxxx>
Date:   Mon Mar 7 13:23:01 2016 +0000

    Fix translator word order control in load-edit
    
    The load-edit widget had a phrase passed as separate translated words,
    which makes it impossible for translators to control the word order.
    This patch passes it as a single translation, fixing the issue.
    
    Change-Id: I0dfd8e098b84241070a69938611a7e33ca3ab35a
    Closes-Bug: 1553610


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1553610

Title:
  ng launch instance workflow: hard to control the word order in
  translations

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  The following commit recently merged introduces a difficult situation
  for translations.

  commit be9023d86e058d81d6c2504e87c3a385f34472e6
      Fix theming in angular launch instance

  horizon/static/framework/widgets/load-edit/load-edit.html

      <span translate>Script size:</span>
      {$ (scriptLength || 0) | bytes $}
      <span translate>of</span>
      {$ config.MAX_SCRIPT_SIZE | bytes $}

  It is "X of Y", but in some languages, a natural order is "trans(Y) trans(of) trans(X)".
  The current code does not allow translators to control the word order.

  angular-gettext allows Interpolation.
  The above should be like:

    <span translation>Script size: {{scriptLength}} of
  {{max_size}}</span>

  Unfortunately I am not familiar with how to use interpolate with
  filter. It would be nice if someone takes this bug.

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1553610/+subscriptions