← Back to team overview

yahoo-eng-team team mailing list archive

[Bug 1553619] Re: string in nova.service.js cannot control the word order in translations Edit Bug

 

Reviewed:  https://review.openstack.org/288947
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=075d9b3624d33c924a88e0d1b77e87378d770f86
Submitter: Jenkins
Branch:    master

commit 075d9b3624d33c924a88e0d1b77e87378d770f86
Author: Akihiro Motoki <motoki@xxxxxxxxxxxxx>
Date:   Sun Mar 6 08:27:49 2016 +0900

    Use interpolate in JS to allow translators to control word order
    
    String concatenation is not recommended for better translation.
    
    Change-Id: I56cd604d88693dadc85ec06f4b4220a63151f2ee
    Closes-Bug: #1553619


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1553619

Title:
  string in nova.service.js cannot control the word order in
  translations Edit Bug

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  openstack_dashboard/static/app/core/openstack-service-
  api/nova.service.js

        return suppressError ? promise : promise.error(function() {
          toastService.add('error', gettext('Unable to delete the flavor with id: ') + flavorId);
        });

  String concatenation should not be used.
  https://docs.djangoproject.com/en/1.8/topics/i18n/translation/#interpolate

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1553619/+subscriptions


References