yahoo-eng-team team mailing list archive

[OpenStack Infra <1553581@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/289039
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=ce6e34a5e4c8841ff0d8da738339cb374beb0949
Submitter: Jenkins
Branch:    master

commit ce6e34a5e4c8841ff0d8da738339cb374beb0949
Author: Akihiro Motoki <motoki@xxxxxxxxxxxxx>
Date:   Mon Mar 7 00:58:00 2016 +0900

    Honor comments for translators when extracting messages
    
    To extract commments for translators, '--add-comments' option
    must be passed to pybabel. Comments for translators were extracted
    when we used Django tools to extract messages, but when we switched
    to pybabel it was lost. This commit adds the option to run_tests.sh.
    
    Move the place of existing comments for translators
    so that pybabel can find them. Django tool and pybabel
    expect a bit different places.
    Also add comments to ungettext_lazy in test codes.
    
    Closes-Bug: #1553581
    Change-Id: Ia2df36dfebb59bede19d57b2158a907126ca1944


** Changed in: horizon
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Dashboard (Horizon).
https://bugs.launchpad.net/bugs/1553581

Title:
  PO file: translator notice is ignored

Status in OpenStack Dashboard (Horizon):
  Fix Released

Bug description:
  After Horizon team decided to use pybabel to extract message catalogs,
  "Comments for Translators" [1] are ignored.
  PyBabel does not support "Comments for Translators".
  Is there any solution?

  I see several strings in our test codes are marked as translatable and they have no translation comments.
  I tried to add comments for translators, but I failed to do it.

  Pybabel migration almost succeeds but it is one of drawbacks.
  We are now not compatible with Django standard way.

  To raise an attraction, I intentionally target it to Mitaka-RC1.
  Feel free to move it out.

  [1] https://docs.djangoproject.com/es/1.9/topics/i18n/translation
  /#comments-for-translators

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1553581/+subscriptions