yahoo-eng-team team mailing list archive

[OpenStack Infra <1512207@xxxxxxxxxxxxxxxxxx>]

Reviewed:  https://review.openstack.org/264607
Committed: https://git.openstack.org/cgit/openstack/os-net-config/commit/?id=e87fac0224b8f61ea8df4b219d1c4a5f76ee1915
Submitter: Jenkins
Branch:    master

commit e87fac0224b8f61ea8df4b219d1c4a5f76ee1915
Author: Swapnil Kulkarni (coolsvap) <me@xxxxxxxxxxxx>
Date:   Thu Jan 7 12:13:40 2016 +0530

    Use assertTrue/False instead of assertEqual(T/F)
    
    The usage of assertEqual(True/False, ***) should be changed
    to a meaningful format of assertTrue/False(***).
    
    Change-Id: Ic15b6ebff7f050c1d516d9d680f362609803da4c
    Closes-Bug:#1512207


** Changed in: os-net-config
       Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to OpenStack Compute (nova).
https://bugs.launchpad.net/bugs/1512207

Title:
  Fix usage of assertions

Status in Aodh:
  Fix Released
Status in Barbican:
  Fix Released
Status in Blazar:
  In Progress
Status in Cinder:
  Invalid
Status in congress:
  Fix Released
Status in Cue:
  Fix Released
Status in Glance:
  Won't Fix
Status in Group Based Policy:
  In Progress
Status in OpenStack Dashboard (Horizon):
  Fix Released
Status in OpenStack Identity (keystone):
  Fix Released
Status in kuryr:
  Fix Released
Status in Magnum:
  In Progress
Status in Manila:
  Fix Released
Status in Murano:
  Fix Released
Status in neutron:
  Fix Released
Status in OpenStack Compute (nova):
  Invalid
Status in OpenStack Health:
  In Progress
Status in os-brick:
  Fix Released
Status in os-net-config:
  Fix Released
Status in os-testr:
  In Progress
Status in oslo.cache:
  Fix Released
Status in oslo.messaging:
  Fix Released
Status in Packstack:
  Fix Released
Status in python-barbicanclient:
  In Progress
Status in python-ceilometerclient:
  Fix Released
Status in python-novaclient:
  Fix Released
Status in python-openstackclient:
  Fix Released
Status in OpenStack SDK:
  Fix Released
Status in Rally:
  Fix Released
Status in requests-mock:
  In Progress
Status in Sahara:
  Fix Released
Status in shaker:
  Fix Released
Status in Solum:
  Fix Released
Status in Stackalytics:
  Fix Released
Status in OpenStack Object Storage (swift):
  In Progress
Status in tempest:
  In Progress
Status in Trove:
  Fix Released
Status in Vitrage:
  Fix Released
Status in watcher:
  Fix Released
Status in zaqar:
  Fix Released

Bug description:
  Manila  should use the specific assertion:

    self.assertIsTrue/False(observed)

  instead of the generic assertion:

    self.assertEqual(True/False, observed)

To manage notifications about this bug go to:
https://bugs.launchpad.net/aodh/+bug/1512207/+subscriptions