yahoo-eng-team team mailing list archive
-
yahoo-eng-team team
-
Mailing list archive
-
Message #48753
[Bug 1563028] Re: Routes version 2.3 broke the way we register routes
Reviewed: https://review.openstack.org/298855
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c6efa6292cac9267428366dc3cee00f6fc73e208
Submitter: Jenkins
Branch: master
commit c6efa6292cac9267428366dc3cee00f6fc73e208
Author: Cedric Brandily <zzelle@xxxxxxxxx>
Date: Tue Mar 29 18:06:44 2016 +0200
Support Routes==2.3
SubMapper.connect allows in Routes<=2.2 to define routes with/without a
name:
map.connect(route_name, route_path)
map.connect(route_path)
Routes==2.3 SubMapper.connect now requires a route name (but not
Mapper.connect). This change adds a route name when needed to support
Routes<=2.2 and Routes==2.3.
Closes-Bug: #1563028
Change-Id: I655bfe7f047945896d63dd94c584acfe60d81b38
** Changed in: neutron
Status: In Progress => Fix Released
--
You received this bug notification because you are a member of Yahoo!
Engineering Team, which is subscribed to neutron.
https://bugs.launchpad.net/bugs/1563028
Title:
Routes version 2.3 broke the way we register routes
Status in neutron:
Fix Released
Status in Trove:
In Progress
Bug description:
Routes v2.3 which just came out included this change
https://github.com/bbangert/routes/commit/0a417004be7e2d950bdcd629ccf24cf9f56ef817
which changed submap.connect() in a way that broke the way Trove
registers routes.
We now need to provide a routename and a path as independent
arguments.
I tried to make sense of the documentation at
http://routes.readthedocs.org/en/v2.3/setting_up.html#submappers and
got nowhere in a hurry, but reading the code for connect() provided a
possible solution.
This will likely need to go to stable/mitaka as well.
To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1563028/+subscriptions